NON-OS/nonos-micro-kernel
Watch
2
0
Fork
You've already forked nonos-micro-kernel
 0
Code Issues Pull requests 22 Projects Releases 1 Packages Wiki Activity

features: say which posture refuses nonos-dev-attest #159

Open
nonos-sync wants to merge 2 commits from nonos-sync/gh-610 into main AGit
pull from: nonos-sync/gh-610
merge into: NON-OS:main
Conversation 0 Commits 2 Files changed 1 +2 -1
nonos-sync commented 2026-10-10 01:56:02 -04:00
Member
Copy link

@eKisNonos, a comment fix.

The nonos-dev-attest comment in Cargo.toml said nonos-production refuses it in src/lib.rs. It doesn't: the guard there is keyed on nonos-release, and it has to be. microkernel-desktop-gui and microkernel-setup-wizard (and 53 other features) turn on nonos-production themselves, and the dev profile (qemu-dev in tools/nix/config.nix) is exactly desktop-gui + setup-wizard + nonos-dev-attest. A compile_error! on production + dev-attest would therefore break make dev-image.

The real guard (nonos-release, which config.nix:146 adds for every non-dev loader, plus the config.nix:167 assert) is correct. Only the comment changes.

Opened on GitHub by senseix21 as pull request 610. Review and merge happen there while this repository is kept in step from GitHub; this copy follows it, and is marked merged or closed when it is.

@eKisNonos, a comment fix. The `nonos-dev-attest` comment in `Cargo.toml` said `nonos-production` refuses it in `src/lib.rs`. It doesn't: the guard there is keyed on `nonos-release`, and it has to be. `microkernel-desktop-gui` and `microkernel-setup-wizard` (and 53 other features) turn on `nonos-production` themselves, and the dev profile (`qemu-dev` in `tools/nix/config.nix`) is exactly desktop-gui + setup-wizard + `nonos-dev-attest`. A `compile_error!` on production + dev-attest would therefore break `make dev-image`. The real guard (`nonos-release`, which `config.nix:146` adds for every non-dev loader, plus the `config.nix:167` assert) is correct. Only the comment changes. --- Opened on GitHub by senseix21 as [pull request 610](https://github.com/NON-OS/microkernel/pull/610). Review and merge happen there while this repository is kept in step from GitHub; this copy follows it, and is marked merged or closed when it is.
The comment on nonos-dev-attest said nonos-production refuses it in
src/lib.rs. It does not: the guard there is keyed on nonos-release, and it
has to be, because microkernel-desktop-gui and microkernel-setup-wizard
carry nonos-production into the dev profile, which is the one profile that
turns nonos-dev-attest on. A reader trusting the comment would believe a
plain cargo build with both features is refused when it compiles.
nonos-sync changed title from WIP: features: say which posture refuses nonos-dev-attest to features: say which posture refuses nonos-dev-attest 2026-10-10 05:09:40 -04:00
This pull request can be merged automatically.
This branch is out-of-date with the base branch
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin +refs/pull/159/head:nonos-sync/gh-610
git switch nonos-sync/gh-610
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
NON-OS/nonos-micro-kernel!159
No description provided.